Skip to content

I18N: Add missing translator comments and fix string issues for 7.0#11152

Open
sanketio wants to merge 1 commit intoWordPress:trunkfrom
sanketio:fix/64244
Open

I18N: Add missing translator comments and fix string issues for 7.0#11152
sanketio wants to merge 1 commit intoWordPress:trunkfrom
sanketio:fix/64244

Conversation

@sanketio
Copy link

@sanketio sanketio commented Mar 4, 2026

Summary

This PR addresses several I18N string improvements as part of the WordPress 7.0 release cycle.

Changes

  • Added missing translator comments to several user-facing error messages that lacked context for translators. These include SMTP-related error strings and informational messages containing technical terms (PHP function names, protocol extension names, and email standard names) that translators need to know should not be translated.
  • Fixed a misplaced translator comment that was positioned too far from its associated translatable string (separated by a conditional block), causing translation tooling such as WP-CLI i18n make-pot and Poedit to fail to associate the comment with the string.
  • Fixed inconsistent capitalization in a user-facing warning string where the first word after the label prefix was lowercase, inconsistent with WordPress core style.

Trac ticket

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sanketparmar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

*/
public static function setLanguage( $langcode = 'en', $lang_path = '' ) {
static::$language = array(
/* translators: SMTP authentication error message. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For string what is benefit of having translators comment here? Better to use that when use placeholders (e.g., %s, %d).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants