Add handling for DW_LNS_set_epilogue_begin in wasm debug info#8414
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Mar 5, 2026
Merged
Add handling for DW_LNS_set_epilogue_begin in wasm debug info#8414kripken merged 1 commit intoWebAssembly:mainfrom
kripken merged 1 commit intoWebAssembly:mainfrom
Conversation
kripken
reviewed
Mar 4, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Thanks!
This looks right to me, but I'm not a DWARF expert. I wonder if there is some additional testing we can do here? (The current tests in this repo are pretty minimal for DWARF)
Contributor
Author
|
Yeah also not an expert but what extra tests would you suggest? I can have a go at adding them |
Member
|
I'm not really sure either. I ran the emscripten tests against this, and they all passed, at least. Maybe that's good enough, landing. |
kripken
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran in to this issue when using wasm-opt with wasm produced with Rust 1.93.1
I've basically copied DW_LNS_set_prologue_end. The test binary is a modified version of the binary used for the existing test for prologue end too