fix: support dragging multiple blocks into a single column#2535
Open
Noyce-Joel wants to merge 1 commit intoTypeCellOS:mainfrom
Open
fix: support dragging multiple blocks into a single column#2535Noyce-Joel wants to merge 1 commit intoTypeCellOS:mainfrom
Noyce-Joel wants to merge 1 commit intoTypeCellOS:mainfrom
Conversation
|
@Noyce-Joel is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When dragging multiple selected blocks to the edge of another block, only the first block was moved into the new column. The remaining blocks were left in place. This fix iterates over all children in the drag slice so all selected block are moved into the column.
Rationale
handleDropinMultiColumnDropCursorPlugin.tsonly extractedslice.content.child(0)from the selected blocks being dragged, ignoring the other selected blocks. This means multiblock dragging to a column was dropping content.Changes
Impact
Shouldn't be any impact on existing single-block drag behaviour and multiblock column drops now work as expected.
Testing
list.
-Single block drag to column works as before.
Screenshots/Video
Screen.Recording.2026-03-03.at.20.56.43.mov
Checklist