test(angular-query/injectMutation): add test for 'throwOnError' with 'mutate' by sukvvon · Pull Request #10219 · TanStack/query

sukvvon · 2026-03-04T10:28:36Z

🎯 Changes

Add test for throwOnError: true with mutate() (non-async) in injectMutation.

Existing tests only covered throwOnError with mutateAsync, which handles errors via Promise rejection. This test covers the subscriber callback path (lines 152-153) where the error is emitted via ngZone.onError and thrown directly.

This improves inject-mutation.ts coverage from 96% to 100%.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Enhanced test coverage for mutation error handling behavior with the throwOnError option enabled.

…'mutate'

changeset-bot · 2026-03-04T10:28:42Z

⚠️ No Changeset found

Latest commit: 3938ded

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-04T10:28:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ed82adc9-6885-472b-9739-28cbf9284be2

📥 Commits

Reviewing files that changed from the base of the PR and between 8a59b2d and 3938ded.

📒 Files selected for processing (1)

packages/angular-query-experimental/src/__tests__/inject-mutation.test.ts

📝 Walkthrough

Walkthrough

A new test case was added to the inject-mutation test suite, verifying that when throwOnError is true, a rejected mutation promise properly throws an error asynchronously on the next timer advancement.

Changes

Cohort / File(s)	Summary
Mutation Error Handling Test `packages/angular-query-experimental/src/__tests__/inject-mutation.test.ts`	Added test case within the "throwOnError" describe block to validate that mutations with `throwOnError: true` properly reject on timer advancement when the mutation function fails.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

fix(chore): report errors of mutation callbacks asynchronously #9675: Implements the mutation callback async error-reporting behavior using Promise.reject that this test case validates

Poem

🐰 A test hops in with care so keen,
To catch the errors that can't be seen,
When throwOnError stands up tall,
The promise rejects—we've tested it all! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a test for throwOnError with the mutate method in injectMutation.
Description check	✅ Passed	The description follows the template structure with all required sections completed: Changes (with clear explanation and coverage improvement), Checklist (all items checked/marked appropriately), and Release Impact (correctly marked as dev-only).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-04T10:29:05Z

View your CI Pipeline Execution ↗ for commit 3938ded

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 22s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-04 10:32:29 UTC

pkg-pr-new · 2026-03-04T10:30:17Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10219

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10219

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10219

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10219

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10219

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10219

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10219

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10219

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10219

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10219

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10219

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10219

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10219

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10219

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10219

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10219

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10219

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10219

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10219

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10219

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10219

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10219

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10219

commit: f0fe133

test(angular-query/injectMutation): add test for 'throwOnError' with …

3938ded

…'mutate'

github-actions bot added the package: angular-query-experimental label Mar 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(angular-query/injectMutation): add test for 'throwOnError' with 'mutate'#10219

test(angular-query/injectMutation): add test for 'throwOnError' with 'mutate'#10219
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/angular-query-inject-mutation-throwOnError

sukvvon commented Mar 4, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 4, 2026

Uh oh!

coderabbitai bot commented Mar 4, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Mar 4, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 4, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

nx-cloud bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Mar 4, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 4, 2026 •

edited

Loading

nx-cloud bot commented Mar 4, 2026 •

edited

Loading