Skip to content

feat: Add Angular Adapter#31

Merged
KevinVandy merged 17 commits intoTanStack:mainfrom
benjavicente:main
Mar 8, 2026
Merged

feat: Add Angular Adapter#31
KevinVandy merged 17 commits intoTanStack:mainfrom
benjavicente:main

Conversation

@benjavicente
Copy link
Contributor

🎯 Changes

This PR adds an Angular Adapter + examples for each main function exported.

There is not devtools package yet, since there is no createAngularPlugin in @tanstack/devtools-utils.

I had to dowgrade TS from 5.9 to 5.8 since it's the latest TS version Angular 19 supports. It supports angular 19 and up since 19 is the oldest with LTS.

A lot of the code was AI asisted, but I reviewed and refractored the adapter to match as closelly as the solid adapter.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@KevinVandy
Copy link
Member

KevinVandy commented Feb 21, 2026

Hi, I'm also following along with this PR. Consider merging main back in to resolve some larger conflicts.

The sequence was rewritten to a much more in-depth sequence-manager today with full parity with the hot-key manager.

@KevinVandy KevinVandy changed the title Add Angular Adapter feat: Add Angular Adapter Feb 23, 2026
@benjavicente
Copy link
Contributor Author

Rebased the branch with the sequence-manager 🏃

For the input signal issue: I added a temporary approach in injectHotkeyRecorder to create the store (HotkeyRecorder) post initialization in a stable signal. We could swap that to a standardized solution when we land something in TanStack/store#284 (discussion) or TanStack/store#285 (alternative API PR).

@benjavicente benjavicente marked this pull request as ready for review February 24, 2026 02:11
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2026

Open in StackBlitz

@tanstack/angular-hotkeys

npm i https://pkg.pr.new/@tanstack/angular-hotkeys@31

@tanstack/hotkeys

npm i https://pkg.pr.new/@tanstack/hotkeys@31

@tanstack/hotkeys-devtools

npm i https://pkg.pr.new/@tanstack/hotkeys-devtools@31

@tanstack/preact-hotkeys

npm i https://pkg.pr.new/@tanstack/preact-hotkeys@31

@tanstack/preact-hotkeys-devtools

npm i https://pkg.pr.new/@tanstack/preact-hotkeys-devtools@31

@tanstack/react-hotkeys

npm i https://pkg.pr.new/@tanstack/react-hotkeys@31

@tanstack/react-hotkeys-devtools

npm i https://pkg.pr.new/@tanstack/react-hotkeys-devtools@31

@tanstack/solid-hotkeys

npm i https://pkg.pr.new/@tanstack/solid-hotkeys@31

@tanstack/solid-hotkeys-devtools

npm i https://pkg.pr.new/@tanstack/solid-hotkeys-devtools@31

commit: cd50e61

@adamwendel
Copy link

adamwendel commented Mar 4, 2026

I can see that a rebase was performed last week, but conflicts already exist again. I'm guessing that because the library is iterating quickly that non-react adapters are going to take some time to get merged in?

Edit: Should've done a bit more homework. looks like the README points out React/Preact/Solid are in but Angular et al. say they need contributors. But the only adapter listed in the Tanstack docs right now is React. Apologies!

@benjavicente
Copy link
Contributor Author

I'm guessing that because the library is iterating quickly that non-react adapters are going to take some time to get merged in?

@adamwendel the issue was that TS versions didn't match, I think we only need some reviews 😃

@KevinVandy
Copy link
Member

I upgraded to angular 21 to be consistent with our other tanstack packages, but kept the peer dep at >19

@KevinVandy KevinVandy merged commit c173ed0 into TanStack:main Mar 8, 2026
3 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants