Conversation
|
Hi, I'm also following along with this PR. Consider merging main back in to resolve some larger conflicts. The |
|
Rebased the branch with the sequence-manager 🏃 For the input signal issue: I added a temporary approach in |
@tanstack/angular-hotkeys
@tanstack/hotkeys
@tanstack/hotkeys-devtools
@tanstack/preact-hotkeys
@tanstack/preact-hotkeys-devtools
@tanstack/react-hotkeys
@tanstack/react-hotkeys-devtools
@tanstack/solid-hotkeys
@tanstack/solid-hotkeys-devtools
commit: |
|
I can see that a rebase was performed last week, but conflicts already exist again. I'm guessing that because the library is iterating quickly that non-react adapters are going to take some time to get merged in? Edit: Should've done a bit more homework. looks like the README points out React/Preact/Solid are in but Angular et al. say they need contributors. But the only adapter listed in the Tanstack docs right now is React. Apologies! |
- unregister factory in injector token - cleanup at the end instead of injectHotkeys - readonly hotkey recorder
@adamwendel the issue was that TS versions didn't match, I think we only need some reviews 😃 |
|
I upgraded to angular 21 to be consistent with our other tanstack packages, but kept the peer dep at >19 |
🎯 Changes
This PR adds an Angular Adapter + examples for each main function exported.
There is not devtools package yet, since there is no
createAngularPluginin@tanstack/devtools-utils.I had to dowgrade TS from 5.9 to 5.8 since it's the latest TS version Angular 19 supports. It supports angular 19 and up since 19 is the oldest with LTS.
A lot of the code was AI asisted, but I reviewed and refractored the adapter to match as closelly as the solid adapter.
✅ Checklist
pnpm run test:pr.🚀 Release Impact