fix: treat empty SOCKET_API_TOKEN as unset#36
Merged
mikolalysenko merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
When SOCKET_API_TOKEN is set to an empty string, the CLI should
fall back to the public proxy path (same as when the variable is
completely unset). Previously, `std::env::var().ok()` returned
`Some("")` for an empty-but-set variable, which passed the
`is_none()` check and sent the empty token to the authenticated
API endpoint, causing "Unauthorized" errors.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SOCKET_API_TOKENis set to an empty string (e.g.SOCKET_API_TOKEN=""), the CLI should fall back to the public proxy path, same as when the variable is completely unsetstd::env::var("SOCKET_API_TOKEN").ok()returnedSome("")for an empty-but-set variable, which passed theis_none()check and sent the empty token to the authenticated API endpoint, causing "Unauthorized" errors.filter(|t| !t.is_empty())to treat empty strings asNoneTest plan
SOCKET_API_TOKEN="" socket-patch get <uuid>now correctly uses the public proxy and succeedsSOCKET_API_TOKEN: ''to simulate unauthenticated usage)🤖 Generated with Claude Code