Draft
Conversation
The `unused_features` lint was introduced in [1], presumably landing in Rust 1.96.0. We simplified the way we use features in #102, always enabling them when building the crate with certain features enabled. For this reason allow the lint. Link: rust-lang/rust#152164 [1] Signed-off-by: Benno Lossin <lossin@kernel.org>
nbdd0121
approved these changes
Mar 6, 2026
Member
nbdd0121
left a comment
nbdd0121
left a comment
There was a problem hiding this comment.
We would also need to enable this in general for other kernel crates, I think?
Member
Author
|
Yes, I already notified Miguel (although in the kernel it only is a warning as opposed to here where it is an error due to our |
Member
|
There's CONFIG_WERROR so it's also problematic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unused_featureslint was introduced in rust-lang/rust#152164, presumably landing in Rust 1.96.0. We simplified the way we use features in #102, always enabling them when building the crate with certain features enabled. For this reason allow the lint.I plan to also add a new CI run that enables the lint & checks if we can remove certain features. Will do so at a later point in time.
This PR fixes the CI failure observed in https://github.com/Rust-for-Linux/pin-init/actions/runs/22754182535