Add quotes to prevent potential word splittings#590
Open
zzmic wants to merge 1 commit intoRenderKit:masterfrom
Open
Add quotes to prevent potential word splittings#590zzmic wants to merge 1 commit intoRenderKit:masterfrom
zzmic wants to merge 1 commit intoRenderKit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests, this PR includes the commit that adds quotes to several commands in
scripts/download_gfx.shto prevent potential word splittings (FYI, https://www.shellcheck.net/wiki/SC2086). In particular, the previous line ofrm -rf /tmp/${GFX_DRIVER}is concerning, since${GFX_DRIVER}is unquoted, (1) if it contains whitespaces, it would be split into multiple arguments torm -rf, and (2) if it is empty or resolves unexpectedly, the command becomesrm -rf /tmp/, which is even more catastrophic. Other quotes are added more for the sake of consistency, even though they do address the valid concern of word splitting (but they are not as concerning asrm -rf /tmp/${GFX_DRIVER}).