Conversation
When UTF-8 conversion in performed during assignment to a factor, make sure that the source strings are also looked up in their UTF-8 form, not the original vector. Fixes: #7648
aitap
changed the title
memrecycle: _actually_ match assigned string to factor levels in UTF-8memrecycle: actually match assigned string to factor levels in UTF-8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7657 +/- ##
==========================================
- Coverage 99.02% 99.02% -0.01%
==========================================
Files 87 87
Lines 16897 16896 -1
==========================================
- Hits 16733 16732 -1
Misses 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit e1c2a28 Download link for the artifact containing the test results: ↓ atime-results.zip
|
MichaelChirico
approved these changes
Mar 3, 2026
Co-Authored-By: Michael Chirico <chiricom@google.com>
aitap
added a commit
that referenced
this pull request
Mar 3, 2026
#7657) * Test case * memrecycle: look up source from converted vector When UTF-8 conversion in performed during assignment to a factor, make sure that the source strings are also looked up in their UTF-8 form, not the original vector. Fixes: #7648 * NEWS entry * Clarify comment, drop a temporary value Co-authored-by: Michael Chirico <chiricom@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, after all UTF-8 conversions and marks being set (first in
TRUELENGTH, later in the hash), the contents of the original, non-convertedsourcewere looked up. This resulted in a level of0being assigned for source strings that failed to match, creating an invalid factor.Fixes: #7648