Skip to content

fix: Properly set separating lines in summary#6

Merged
MariusMerkleQC merged 3 commits intomainfrom
issue_5
Mar 4, 2026
Merged

fix: Properly set separating lines in summary#6
MariusMerkleQC merged 3 commits intomainfrom
issue_5

Conversation

@MariusMerkleQC
Copy link
Collaborator

@MariusMerkleQC MariusMerkleQC commented Mar 3, 2026 •
edited
Loading

Motivation

See #5. There was no line below loyalty_card_id as this specific row had zero change counts.

Changes

  • Added a test summary fixture for the failure case
  • Fixed the summary generation: it now includes separators if any row has a non-zero number of top change counts to show, rather than that specific row's change counts.
  • Adjusted the "hidden summary" section of the summary user guide

@MariusMerkleQC MariusMerkleQC self-assigned this Mar 3, 2026
@MariusMerkleQC MariusMerkleQC linked an issue Mar 3, 2026 that may be closed by this pull request
No separating line in summary with hidden column #5
Closed
@github-actions github-actions bot added the fix label Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8e8689c) to head (875f624).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          703       704    +1     
=========================================
+ Hits           703       704    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MariusMerkleQC
MariusMerkleQC commented Mar 3, 2026
View reviewed changes
@MariusMerkleQC MariusMerkleQC marked this pull request as ready for review March 3, 2026 13:37
Copilot AI review requested due to automatic review settings March 3, 2026 13:37
Copilot AI reviewed Mar 3, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a formatting bug in Diffly’s summary “Columns” section where row separators could disappear when a column is hidden (and thus has zero top-change entries), even though other columns still show top changes.

Changes:

  • Adjusted column-summary rendering so separators are driven by whether any column will display top changes, instead of the current row’s top-change count.
  • Added a hidden-columns fixture generator + updated snapshot fixtures reflecting the new separator behavior.
  • Updated the Summary user guide notebook output for the hidden-columns example.

Reviewed changes

Copilot reviewed 53 out of 53 changed files in this pull request and generated no comments.

Show a summary per file
File Description
diffly/summary.py Fixes separator insertion logic in the “Columns” section when top changes are present globally but absent for specific rows (e.g., hidden columns).
docs/guides/features/summary.ipynb Updates documentation output to include the missing horizontal separator in the hidden-columns example.
tests/summary/fixtures/hidden_columns/test_hidden_columns.py Adds a fixture generator covering the hidden-columns failure case.
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False_hidden.txt Adds/updates “hidden columns” snapshot variant (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=True).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False_hidden.txt Adds/updates “hidden columns” snapshot variant (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/hidden_columns/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt Updated snapshot output for hidden-columns fixture (pretty=False).
tests/summary/fixtures/many_pk_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/many_pk_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/many_pk_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/many_pk_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/lost_rows_only/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/lost_rows_only/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/lost_rows_only/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/lost_rows_only/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/gained_rows_only/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/gained_rows_only/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/gained_rows_only/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/gained_rows_only/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt Updates snapshots due to adjusted separator rendering.
tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt Updates snapshots due to adjusted separator rendering.
Comments suppressed due to low confidence (1)

tests/summary/fixtures/hidden_columns/test_hidden_columns.py:16

  • pretty is parametrized but not used; the test loops over [True, False] and writes both outputs on every run, so the parametrization causes duplicate work and repeated writes. Consider either using the pretty parameter directly (like other fixture generator tests) or removing the parametrization and keeping the loop, so the test runs only once.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@borchero borchero changed the title fix: Summary with separating line despite hidden column fix: Properly set separating lines in summary Mar 4, 2026
@MariusMerkleQC MariusMerkleQC merged commit fb90a0e into main Mar 4, 2026
30 checks passed
@MariusMerkleQC MariusMerkleQC deleted the issue_5 branch March 4, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@borchero borchero borchero approved these changes

@EgeKaraismailogluQC EgeKaraismailogluQC Awaiting requested review from EgeKaraismailogluQC EgeKaraismailogluQC is a code owner

Assignees

@MariusMerkleQC MariusMerkleQC

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No separating line in summary with hidden column

3 participants

@MariusMerkleQC @borchero