Update CFS and other OneBranch tooling#1422
Open
andyleejordan wants to merge 5 commits intoPowerShell:mainfrom
Open
Update CFS and other OneBranch tooling#1422andyleejordan wants to merge 5 commits intoPowerShell:mainfrom
andyleejordan wants to merge 5 commits intoPowerShell:mainfrom
Conversation
The crux of our problems was the cross-org feed permissions.
The version ms-stable stopped being supported in 2024 so we've been on an old toolchain.
Which removes the need to do complicated authentication.
Member
Author
|
Watching the OneBranch run, it failed on Windows only at the signing step due to the internal service timing out, so I think this is at least good to go for review. Edit: found the reason for that, and for the previously added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the course of debugging why we couldn't so much as
cargo install tree-sitter-cliI discovered a number of issues resolved in this PR.For the
msrustuptoolchain,ms-stablestopped being supported in 2024, meaning under the covers we've just been usingms-prod-1.88. I've updated the OneBranch pipelines to specifically usems-prod-1.93. The OneBranch documentation recommends a specific pin, and not e.g.ms-prod. They also recommend using arust-toolchain.tomlfile, but that gets a bit in the way of our existing logic which detects and usesmsrustuponly when available.I've switched us from the mscodehub CFS feed to a new dedicated
DSCCargoMirrorCFS feed in msazure. By not being cross-org, we don't have to deal with complicated authentication with a service connection, and can just rely on theCargoAuthenticatetask. I know of no compelling reason to stick to the mscodehub feed when we can eliminate a lot of headache here.If and when as a dev you cannot update the feed, there is a very hidden button titled "Allow externally-sourced versions" available only after going to the feed and searching the upstream sources for a package. I've found it sometimes just gets turned off, which then prevents us from adding packages to the feed, and this will appear as an authentication failure. Authenticating locally with either
artifacts-cargo-credproviderormsrustupdoes indeed work, but that setting must be toggled on.I removed
ob_restore_phase: trueas that was an old workaround for accessing network resources that were not allow-listed, and it messed up the timing of the tasks.