fix: resolve ruler function/module name collision#587
Open
koriyoshi2041 wants to merge 1 commit intoOpenPipe:mainfrom
Open
fix: resolve ruler function/module name collision#587koriyoshi2041 wants to merge 1 commit intoOpenPipe:mainfrom
koriyoshi2041 wants to merge 1 commit intoOpenPipe:mainfrom
Conversation
Export DEFAULT_RUBRIC from art.rewards to make it accessible despite the name collision between the ruler() function and the ruler module. Also accept rubric=None in ruler() and ruler_score_group() so callers can reference the default without importing the constant. Both functions resolve None to DEFAULT_RUBRIC defensively at their own entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #339.
DEFAULT_RUBRICfromart.rewardsso users can access it viafrom art.rewards import DEFAULT_RUBRIC, bypassing the function/module name collisionrubric=Nonein bothruler()andruler_score_group(), resolving toDEFAULT_RUBRICinternally — this lets users reference the default without importing the constantNoneat their own entry point for defensive consistencyBackground
art.rewards.__init__.pyimports theruler()function fromruler.py, which shadows therulermodule. This makesart.rewards.ruler.DEFAULT_RUBRIC(and any other module-level export) inaccessible:After this change
Fully backward-compatible — existing callers passing a string are unaffected.
Test plan
from art.rewards import DEFAULT_RUBRICworksruler(message_lists, rubric=None)uses the default rubricruler_score_group(group, rubric=None)uses the default rubricrubric="..."still workuv run prek run --all-filespasses