fix: Item Overlay regex for Windows paths

[Alex33856]

No description provided.

[lineargraph]

huh, is this actually an issue on windows? how does it manifest? all the paths should really just be slashes anyway, hmm. can you tell me about how you get errors with this?

[Alex33856]

Without this, zero item overlays are loaded on Windows, because NEURepoFile#getPath returns the path with backslashes.

[lineargraph]

how are you using this project? could you show me a use case that fails on windows (git branch or a .java file)? .java would be nice because then i could actually put that in a github action test

[Alex33856]

how are you using this project?

It's used in Skyblocker to parse the NEU repo items and item overlays.
Here is where it checks for and applies overlays if they exist.

could you show me a use case that fails on windows (git branch or a .java file)? .java would be nice because then i could actually put that in a github action test

I don't have an easily separable way to reproduce this outside of Minecraft and Skyblocker.

The problem I'm facing is that certain SkyBlock items (Wither Scrolls, Power Scrolls, Totem of Corruption) have additional NBT data (Item Model, Banner Patterns) that is not present in the item file, but in an overlay file.
We create an ItemStack from the repo item and attempt to apply an overlay if one exists.
Because of this issue, on Windows, the ItemStack is missing that additional NBT data and thus does not visually match the actual SkyBlock item.

To replicate in-game with Skyblocker (any version, 1.21.10/1.21.11):

• Join SkyBlock
• Open the recipe book, and wait for it to load if it hasn't already
• Search for Totem of Corruption

On Windows, it appears as a white banner

On other platforms, it appears properly with a black/purple banner pattern.

[Alex33856]

This test can replicate the issue.

java.lang.NullPointerException: Cannot invoke "io.github.moulberry.repo.data.ItemOverlays$ItemOverlayFile.getVersion()" because the return value of "java.util.Map.get(Object)" is null

	at io.github.moulberry.repo.NEURepoParserTest.testOverlayFiles(NEURepoParserTest.java:28)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

[lineargraph]

perhaps it would make sense to instead make the filepath use forward slashes canonically, even on windows.

[lineargraph]

thank youuu will probably try to figure out how to get the action build running on windows as well