Skip to content

refactor: prevent token fetching being called multiple times #8113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prithpal-Sooriya merged 18 commits into from
Mar 6, 2026
+206 −151
Merged

refactor: prevent token fetching being called multiple times #8113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a325493
Gate TokenListController polling on initialization
cursoragent Mar 4, 2026
c02ac26
Add changelog for TokenListController polling fix
cursoragent Mar 4, 2026
d204ee8
Refactor init-gating tests and silence poll catch
Prithpal-Sooriya Mar 4, 2026
e7b0940
Inline initialize flow and simplify poll tests
Prithpal-Sooriya Mar 4, 2026
1158aa2
Replace initialize IIFE with executeInit helper
Prithpal-Sooriya Mar 4, 2026
06ce317
refactor token list initialize state assignment
Prithpal-Sooriya Mar 4, 2026
18f2d7f
Refactor TokenListController tests and initialization logic
Prithpal-Sooriya Mar 4, 2026
6a47686
Refactor TokenListController test setup and action handlers
Prithpal-Sooriya Mar 4, 2026
4fce25b
test: remove `any` from UTs
Prithpal-Sooriya Mar 4, 2026
61ef1bf
refactor: clean up eslint suppressions
Prithpal-Sooriya Mar 4, 2026
7c11e0e
Merge branch 'main' into cursor/eip712domain-chainid-controller-0711
Prithpal-Sooriya Mar 4, 2026
9d5e668
feat: use popular EVM networks when homepage sections v1 is enabled (…
salimtb Mar 5, 2026
5cf1179
feat(accounts-controller): add logger (#8118)
ccharly Mar 5, 2026
e512f76
feat: Add refundTo for Relay calls (#8112)
dan437 Mar 5, 2026
e64127e
Release/851.0.0 (#8119)
dan437 Mar 5, 2026
a46e7e8
chore!: remove unused methods and state from the `PreferencesControll…
hmalik88 Mar 5, 2026
223243f
perf: Add `accountIdByAddress` to `AccountsController` state (#7893)
hmalik88 Mar 5, 2026
6c9cac3
Merge origin/main into cursor/eip712domain-chainid-controller-0711
Prithpal-Sooriya Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,14 +332,6 @@
"count": 2
}
},
"packages/assets-controllers/src/TokenListController.test.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 1
},
"id-denylist": {
"count": 2
}
},
"packages/assets-controllers/src/TokenRatesController.test.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 4
Expand Down
4 changes: 4 additions & 0 deletions packages/assets-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- When `isHomepageSectionsV1Enabled` is true, `AccountTrackerController` now uses all popular EVM networks (via `NetworkEnablementController:listPopularEvmNetworks`) for balance refresh on account change and keyring unlock, instead of only the enabled networks from `NetworkEnablementController` state ([#8117](https://github.com/MetaMask/core/pull/8117))

### Fixed

- Gate `TokenListController` polling on controller initialization to avoid duplicate token list API requests during startup races ([#8113](https://github.com/MetaMask/core/pull/8113))

## [100.1.0]

### Added
Expand Down
Loading