Open
Conversation
AxelGes
reviewed
Mar 4, 2026
AxelGes
reviewed
Mar 4, 2026
7 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Introduces controller API support for custom-action ramp flows (e.g., PayPal).
What changed:
getBuyWidgetData(quote)— ReplacesgetWidgetUrl. ReturnsBuyWidget | null(url, optionalbrowser, optionalorderId) instead ofstring | null. Returnsnullwhen fetch fails or no URL is available.addPrecreatedOrder(params)— New method accepting{ orderId, providerCode, walletAddress, chainId? }. Parses order IDs (including/orders/path format), normalizesproviderCode(strips/providers/prefix), and inserts a stubRampsOrderinPrecreatedstatus for existing polling to hydrate.What stays untouched: Existing controller state shape, polling behavior, and other order flows remain unchanged aside from the new API surface.
Dependencies: None in core; mobile and extension consume these changes.
References
Checklist
Note
Medium Risk
Medium risk because it introduces a breaking API change (
getWidgetUrl→getBuyWidgetData) and changes error-handling semantics (now throws on service failures), which can break consumers. New order-stub insertion affects order polling/state and could surface edge cases if input parsing/normalization is wrong.Overview
Adds controller support for custom-action ramp flows by introducing
addPrecreatedOrder, which normalizes provider codes and inserts a minimalPrecreatedstubRampsOrderso existing polling can hydrate it later.BREAKING: Replaces
getWidgetUrl()withgetBuyWidgetData()returningBuyWidget | null(including optionalorderId/browser) and now propagatesRampsService:getBuyWidgetUrlerrors instead of swallowing them; exports newnormalizeProviderCodehelper and updates tests/changelog accordingly.Written by Cursor Bugbot for commit 685dbf4. This will update automatically on new commits. Configure here.