feat(credits): remove free $5 credit for new users#928
Closed
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Closed
feat(credits): remove free $5 credit for new users#928kilo-code-bot[bot] wants to merge 1 commit intomainfrom
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Conversation
The automatic-welcome-credits grant is now a no-op. The promo category amount is set to 0 as a safeguard, and the welcome notification referencing the $5 bonus is disabled.
| description: 'Free credits for new users who pass both Turnstile and Stytch validation', | ||
| amount_usd: 5, | ||
| description: 'Free credits for new users who pass both Turnstile and Stytch validation (disabled)', | ||
| amount_usd: 0, |
Contributor
Author
There was a problem hiding this comment.
WARNING: Zeroing this category amount breaks remaining welcome-credit grants
grantCreditForCategory() falls back to the promo config's amount_usd when callers do not override it. src/scripts/d2025-10-07-backfill-github-welcome.ts:85 still grants automatic-welcome-credits without an explicit amount, so this change will create a $0 transaction while still marking the user as having received welcome credits.
Contributor
Author
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Fix these issues in Kilo Cloud Files Reviewed (4 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleSignupPromotion()insrc/lib/stytch.tsis now a no-op — it retains the function signature for backward compatibility (called fromaccount-verification/page.tsx) but no longer grants any credits.automatic-welcome-creditspromo category insrc/lib/promoCreditCategories.tshas itsamount_usdset to0as a belt-and-suspenders safeguard.src/lib/notifications.tsis disabled since it no longer applies to new users.Verification
pnpm typecheck— passes clean across all 29 workspace projectssrc/lib/stytch.test.ts— test now asserts no credit transaction is created (DB tests cannot run in this environment due to missing pg connection, but the test logic is correct)grantCreditForCategory,subDays, andhasReceivedPromotionVisual Changes
N/A
Reviewer Notes
handleSignupPromotionfunction is kept as a no-op rather than fully deleted becauseaccount-verification/page.tsxcalls it. Removing the call entirely would also be fine but this approach is more minimal.automatic-welcome-creditscategory still exists inpromoCreditCategories.ts(withamount_usd: 0) because it's referenced bywelcomeCredits.tsfor checking whether existing users have already received any welcome credits (used in admin tools and customer info).Built for Mark by Kilo for Slack