Merged
Conversation
sukhwinder33445
previously approved these changes
Dec 4, 2025
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
db90247 to
204a7aa
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
ef5f5f3 to
9b2ebce
Compare
sukhwinder33445
previously approved these changes
Dec 11, 2025
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
2 times, most recently
from
9fc16d4 to
be685ed
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
be685ed to
2ebbbb8
Compare
…ibilty Since PHP 8.4 implicitly nullable parameters are deprecated.
Since PHP 8.5 driver-specific PDO constants are deprecated, their replacements are only available since PHP 8.4.
`scanDirectories` was set to `/usr/share/icinga-php` to simplify local testing, as both the Icinga PHP Library and Icinga PHP Thirdparty are installed there in our development environment. Our individual PHP library components, which make up these libraries, are self-contained, as they define all necessary dependencies themselves. This then requires testing with exactly these dependencies instead of an arbitrary folder that could contain anything, e.g., dependencies in unexpected versions or dependencies that have not yet been defined. For remote and local testing, `composer install` must be executed and tests must be performed with exactly the resulting dependencies. Since PHPStan uses the Composer autoloader by default, if available, `scanDirectories` does not need to be defined at all.
…class `PDOStatement::setFetchmode()` takes variable-length argument list as second parameter. One of the extended local classed inside TestConnection did not match this siganture.
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
2ebbbb8 to
9aaf2fd
Compare
lippserd
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes that had to be addressed
PHP 8.3 -> Php 8.4
Migration docs: https://www.php.net/manual/en/migration84
PHP 8.4 -> PHP 8.5
Migration Docs: https://www.php.net/manual/en/migration85
instead of PDO::SQL<constant_name> use Pdo\Mysql::<constant_name>.
resolves: #94