ci(#117): add dotnet format check to CI pipeline#154
Merged
LeeCampbell merged 1 commit intoHdrHistogram:mainfrom Mar 4, 2026
Merged
ci(#117): add dotnet format check to CI pipeline#154LeeCampbell merged 1 commit intoHdrHistogram:mainfrom
LeeCampbell merged 1 commit intoHdrHistogram:mainfrom
Conversation
Insert `dotnet format --verify-no-changes --verbosity diagnostic` step between `dotnet restore` and `dotnet build` so PRs that violate .editorconfig formatting rules fail fast with clear diagnostic output. Stacked on HdrHistogram#152 which provides the nullable warning fixes needed for the format check to pass. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
LeeCampbell
force-pushed
the
feat/117-ci-format-check
branch
from
26a3bff to
4bc236d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet format --verify-no-changes --verbosity diagnosticstep to the CI workflow betweendotnet restoreanddotnet build..editorconfigformatting rules will fail fast with clear diagnostic output naming the offending files.Dependency
This PR is stacked on #152 which provides the nullable warning fixes needed for the format check to pass cleanly.
Merge #152 first, then this PR.
Changes
.github/workflows/ci.yml— single new step inserted after restore, before build.Test plan
dotnet format --verify-no-changesstep appears in the GitHub Actions log.Closes #117
🤖 Generated with Claude Code