DataGrid/TreeList - ColumnChooser - Use new TreeView api instead custom logic in ColumnChooser to restore disabled items selection#32768
Open
Raushen wants to merge 3 commits intoDevExpress:26_1from
Conversation
…ColumnChooser-API-refactoring
Contributor
There was a problem hiding this comment.
Pull request overview
Updates DataGrid/TreeList ColumnChooser selection behavior to rely on TreeView’s newer disabled-node selection API instead of custom re-selection logic, and aligns integration tests with the updated selection state.
Changes:
- Removed custom TreeView selection “repair” logic for
allowHiding === falsenodes on selection changes. - Configured TreeView with
disabledNodeSelectionMode: 'never'in select mode. - Updated an integration test assertion for band-column selection state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnChooser.integration.tests.js | Adjusts assertion/comment to match new band-column selected state produced by TreeView selection logic. |
| packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts | Removes manual disabled-node re-selection and relies on TreeView disabledNodeSelectionMode instead. |
...s/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/columnChooser.integration.tests.js
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/column_chooser/m_column_chooser.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.