Test enforce-groovy-migration workflow#10746
Closed
sarahchen6 wants to merge 3 commits intomasterfrom
Closed
Conversation
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Contributor
Author
|
Apologies in advance for the pings while testing! The PR needs to be in undrafted for the workflow to take effect. Feel free to unsubscribe. |
Contributor
Author
|
Done testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR tests #10730.
Jira ticket: #10744
Testing Results
In
draftmode, the workflow should be skipped (i.e. pass). ✅In
ready to reviewmode...The workflow should fail when a new Groovy test file was created in a migrated module and leave a comment. ✅
The workflow should pass and leave a warning comment when a new Groovy test file was created in a soon-to-be-migrated module (i.e. not already migrated and not smoke tests or instrumentations). After removing the
ShouldError.groovyfile, we also see that the error comment has been deleted. ✅The workflow should pass and leave no comment when a new Groovy test file was created in a
dd-smoke-testsordd-java-agent/instrumentationsmodule, or when an existing Groovy test file was edited. After removing theShouldWarn.groovyfile, we also see that the error comment has been deleted. ✅Finally, the override
tag: override-groovy-enforcementshould skip the workflow entirely. This was tested successfully in the original workflow implementation PR linked at the top of this description. ✅