Skip lightmap + deluxegrid shader permutations compilation and skip “proxy” shader compilation#1927
Open
illwieckz wants to merge 5 commits intofor-0.56.0/syncfrom
Open
Skip lightmap + deluxegrid shader permutations compilation and skip “proxy” shader compilation#1927illwieckz wants to merge 5 commits intofor-0.56.0/syncfrom
illwieckz wants to merge 5 commits intofor-0.56.0/syncfrom
Conversation
- reset line number at GLSL shader start - use custom line number for the GLSL header to avoid line number duplicates - use custom line number for the deform vertex header - reset line count on `#line 0`
…d but not light grid
illwieckz
force-pushed
the
illwieckz/shader-compilation
branch
from
df0edaa to
db83052
Compare
illwieckz
changed the title
illwieckz
changed the title
illwieckz
force-pushed
the
illwieckz/shader-compilation
branch
2 times, most recently
from
3c889e5 to
7ee8d4a
Compare
Member
|
For skipping lightmap + grid deluxe I believe I have a simpler implementation in the first two commits of #1920. |
Member
Author
If that PR has generic fixes that can be merged without the rest of the draft, please submit them separately. =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1863 and #1925:
Includes #1922: