feat: migrate video services to Sanity config system (Phase B)#608
Closed
codercatdev wants to merge 1 commit intodevfrom
Closed
feat: migrate video services to Sanity config system (Phase B)#608codercatdev wants to merge 1 commit intodevfrom
codercatdev wants to merge 1 commit intodevfrom
Conversation
- remotion.ts: awsRegion, serveUrl, functionName from getConfigValue('remotion_config')
- elevenlabs.ts: voiceId from getConfigValue('pipeline_config', 'elevenLabsVoiceId')
- gcs.ts: bucketName, projectId from getConfigValue('gcs_config')
- All use env var fallbacks for migration safety
- Secrets (API keys, AWS credentials) remain as process.env
Co-authored-by: videopipe <videopipe@miriad.systems>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase B Config Migration — Video Services
Migrates configurable values in video pipeline services from direct
process.envreads togetConfigValue()from the Sanity config system. All values use env var fallbacks for backward compatibility.Changes
process.env)lib/services/remotion.tsawsRegion,serveUrl,functionName→remotion_configAWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEYlib/services/elevenlabs.tsvoiceId→pipeline_config.elevenLabsVoiceIdELEVENLABS_API_KEYlib/services/gcs.tsbucketName,projectId→gcs_configGCS_CLIENT_EMAIL,GCS_PRIVATE_KEYMigration Pattern
All values use
getConfigValue(table, key, envFallback)— if Sanity config singletons aren't created yet, the env var fallback ensures existing behavior is preserved.Notable Renames
getConfig()in elevenlabs.ts →getElevenLabsConfig()(avoids collision with config module)RemotionConfiginterface in remotion.ts →RemotionLambdaConfig(avoids collision with config type)Not Changed
lib/services/pexels.ts— only usesPEXELS_API_KEY(secret), no configurable values to migrateZero new TypeScript errors.