feat(drums/tabs): allow showTablature for percussion (drums) notation#2591
Open
leocaseiro wants to merge 2 commits intoCoderLine:developfrom
Open
feat(drums/tabs): allow showTablature for percussion (drums) notation#2591leocaseiro wants to merge 2 commits intoCoderLine:developfrom
leocaseiro wants to merge 2 commits intoCoderLine:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Related to #474
Proposed changes
In this PR, I am allowing the display of tablature for drums as well.
This is useful to identify different patterns in drum guitar pro files. As some drummers use on kick (35) or another (36), or alternative toms that can be considered T1 (high), T2 (medium), or Floor Tom (low), but is quite different from gp file to file.
This feature is already available in Guitar Pro, Tux Guitar, and Soundslice.
Luckily for us, *.gp files already provide the string, and fret as an alternative tuning:
eg.
Checklist
Further details
I have included, as part of

test-data, an example with default values from GuitarPro. (drum-tabs.gp).GuitarPro allows customising the line for each note individually, so I also added a file with custom settings for the same note (e.g., bass drum - 36).