Skip to content

fix: prevent double clipboard alert on copy action #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HardeepAsrani wants to merge 6 commits into
base: development
Choose a base branch
from
+214 −95
Open

fix: prevent double clipboard alert on copy action #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a45d4ec
fix: prevent double clipboard alert on copy action
HardeepAsrani Mar 6, 2026
661aa85
fix: copy still happening twice
HardeepAsrani Mar 9, 2026
28fb9ff
chore: bump version for dev builds
HardeepAsrani Mar 9, 2026
1e851a1
chore: bump version for dev builds
HardeepAsrani Mar 9, 2026
d72847e
chore: bump version for dev builds
HardeepAsrani Mar 9, 2026
1cbc093
chore: bump version for dev builds
HardeepAsrani Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/build-dev-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ jobs:
run: |
composer install --no-dev --prefer-dist --no-progress
- name: Create zip
run: npm run dist
run: |
npm ci
CURRENT_VERSION=$(node -p -e "require('./package.json').version")
COMMIT_HASH=$(git rev-parse --short HEAD)
DEV_VERSION="${CURRENT_VERSION}-dev.${COMMIT_HASH}"
npm run grunt version::${DEV_VERSION}
npm run dist
- name: Retrieve branch name
id: retrieve-branch-name
run: echo "::set-output name=branch_name::$(REF=${GITHUB_HEAD_REF:-$GITHUB_REF} && echo ${REF#refs/heads/} | sed 's/\//-/g')"
Expand Down
9 changes: 5 additions & 4 deletions js/render-facade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
/* global console */
/* global visualizer */
/* global jQuery */
var vizClipboard1=null;
window['vizClipboard1'] = window['vizClipboard1'] || null;
window['vizClipboard2'] = window['vizClipboard2'] || null;
(function($, visualizer){

function initActionsButtons(v) {
Expand All @@ -13,12 +14,12 @@ var vizClipboard1=null;
});
}

if($('a.visualizer-action[data-visualizer-type=copy]').length > 0) {
if($('a.visualizer-action[data-visualizer-type=copy]').length > 0 && vizClipboard2 === null) {
$('a.visualizer-action[data-visualizer-type=copy]').on('click', function(e) {
e.preventDefault();
});
var clipboard = new ClipboardJS('a.visualizer-action[data-visualizer-type=copy]'); // jshint ignore:line
clipboard.on('success', function(e) {
vizClipboard2 = new ClipboardJS('a.visualizer-action[data-visualizer-type=copy]'); // jshint ignore:line
vizClipboard2.on('success', function(e) {
window.alert(v.i10n['copied']);
});
}
Expand Down
Loading
Loading