fix: manual config not working for ChartJS charts#1257
Open
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
Open
fix: manual config not working for ChartJS charts#1257HardeepAsrani wants to merge 1 commit intodevelopmentfrom
HardeepAsrani wants to merge 1 commit intodevelopmentfrom
Conversation
Move override() to after settings.plugins.tooltip is assigned and before new Chart(), so manual config is applied last. Also change $.extend to deep merge so nested plugin options merge rather than replace, preserving tooltip callbacks.
pirate-bot
added
the
pr-checklist-incomplete
Contributor
HardeepAsrani
added
the
pr-checklist-skip
pirate-bot
added
pr-checklist-complete
abaicus
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move override() to after settings.plugins.tooltip is assigned and before new Chart(), so manual config is applied last. Also change $.extend to deep merge so nested plugin options merge rather than replace, preserving tooltip callbacks.
Will affect visual aspect of the product
YES/NO
No
Screenshots
Test instructions
Check before Pull Request is ready:
Closes #1184.