generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 432
London | 26-ITP-January | Dagim Daniel | Sprint 2 | Form-control #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dagim-Daniel
wants to merge
5
commits into
CodeYourFuture:main
Choose a base branch
from
Dagim-Daniel:form-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−9
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7658690
fixing typo errors
Dagim-Daniel 65fbf0f
create the format as requested and also Add style folder for the css
Dagim-Daniel cb94b55
adding submit button to it
Dagim-Daniel 0631795
fix validation error
Dagim-Daniel 1e6e752
fix accessability issues.
Dagim-Daniel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,78 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <p>please enter the required (*) information to order your T-shirt.</p> | ||
| <fieldset> | ||
| <legend>Customer Information</legend> | ||
| <label for="name">Name:*</label> | ||
| <input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| required | ||
| pattern="[A-Za-z\s]{2,50}" | ||
| /> | ||
| <br /> | ||
| <span class="error-message" | ||
| ><p> | ||
| Please enter a valid name (2-50 characters, letters and spaces | ||
| only). | ||
| </p> | ||
| </span> | ||
| <br /> | ||
| <label for="email">Email:*</label> | ||
| <input type="email" id="email" name="email" required /> | ||
| </fieldset> | ||
|
|
||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| customer name, with validation | ||
| customer's email | ||
| ---- The upper one customer information----- | ||
| // | ||
| ---- The lower one product information----- | ||
| color of T-shire (choose one from 3 option) | ||
| size of T-shirt (choose one from xs, s, m, l, xl,xxl)--> | ||
| <fieldset> | ||
| <legend>Product Information</legend> | ||
| <label for="color">Color:*</label> | ||
| <select id="color" name="color" required> | ||
| <option value="">--Please choose a color--</option> | ||
| <option value="red">Red</option> | ||
| <option value="blue">Blue</option> | ||
| <option value="green">Green</option> | ||
| </select> | ||
| <br /> | ||
| <label for="size">Size:*</label> | ||
| <select id="size" name="size" required> | ||
| <option value="">--Please choose a size--</option> | ||
| <option value="xs">XS</option> | ||
| <option value="s">S</option> | ||
| <option value="m">M</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XXL</option> | ||
| </select> | ||
| </fieldset> | ||
| <label for="submit"></label> | ||
| <input type="submit" id="submit" value="Submit Order" /> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> | ||
| <p>By Dagim Daniel</p> | ||
| </footer> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| :root { | ||
| --paper: oklch(7 0 0); | ||
| --ink: color-mix(in oklab, var(--color) 5%, Green); | ||
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --container: 1280px; | ||
| } | ||
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
| body { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| p { | ||
| margin: auto; | ||
| } | ||
| h1 { | ||
| text-align: center; | ||
| } | ||
| input:invalid { | ||
| border-color: rgb(255, 64, 0); | ||
| } | ||
| span { | ||
| font-size: smaller; | ||
| } | ||
| input:valid { | ||
| border-color: green; | ||
| } | ||
| fieldset:focus-within { | ||
| border-color: green; | ||
| } | ||
| footer { | ||
| width: var(--container); | ||
| position: fixed; | ||
| bottom: 0; | ||
| text-align: center; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you delete any unused custom properties to keep the code clean?