Skip to content

Fix token param handling for official GPT-5 model IDs #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeterDaveHello merged 1 commit into from
Mar 7, 2026
Merged

Fix token param handling for official GPT-5 model IDs #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/apis/openai-token-params.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const GPT5_CHAT_COMPLETIONS_MODEL_PATTERN = /(^|\/)gpt-5([.-]|$)/
const GPT5_CHAT_COMPLETIONS_MODEL_PATTERN = /^gpt-5([.-]|$)/

function shouldUseMaxCompletionTokens(provider, model) {
const normalizedProvider = String(provider || '').toLowerCase()
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/services/apis/openai-token-params.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ test('uses max_completion_tokens for gpt-5.x chat models', () => {
})
})

test('uses max_completion_tokens for provider-prefixed gpt-5.x models', () => {
test('uses max_tokens for provider-prefixed gpt-5.x model names', () => {
assert.deepEqual(getChatCompletionsTokenParams('openai', 'openai/gpt-5.2', 2048), {
max_completion_tokens: 2048,
max_tokens: 2048,
})
})

Expand Down