[FIX] Use SQLAlchemy .is_(False) instead of Python identity check in test result filtering

[Atul-Chahar]

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

• I have never used the project.
• I have used the project briefly.
• I have used the project extensively, but have not contributed previously.
• I am an active contributor to the project.

---

Summary

Fixes a silent SQLAlchemy filter bug in get_test_results() (mod_test/controllers.py:102).

The Bug

# Before — Python identity check (always False for a column attribute):
RegressionTestOutput.ignore is False

# After — SQLAlchemy column comparison:
RegressionTestOutput.ignore.is_(False)

RegressionTestOutput.ignore is a Column(Boolean()). Using Python's is False performs an identity check — "is this column attribute the exact same object as False?" — which is always False. This means the and_() filter always evaluates to filter(and_(..., False)), returning no results.

Impact

In the "no result files" branch of get_test_results() (line 98-109), when a regression test has non-ignored output files but the test produced no result files, the broken filter returns nothing. The len(outputs) > 0 check on line 105 is therefore never true, so the test entry is not flagged as an error — silently appearing as passing.

Changes

• 1 line changed in mod_test/controllers.py:102
• pycodestyle ✅ passes
• Module import ✅ successful

Fixes #1042

[Atul-Chahar]

Local Verification

$ ./venv/bin/pycodestyle mod_test/controllers.py --config=.pycodestylerc
(no output — all clean)

$ ./venv/bin/python -c "from mod_test.controllers import *; print('Import OK')"
Import OK

Note: Full test suite requires MySQL which I don't have locally — CI should cover this. The change is a single-line fix to a well-documented SQLAlchemy anti-pattern (is False vs .is_(False)), so the risk is minimal.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud