Fix: Add NULL check after strdup in parse_segment_track_entry#2185
Open
sadiapeerzada wants to merge 2 commits intoCCExtractor:masterfrom
Open
Fix: Add NULL check after strdup in parse_segment_track_entry#2185sadiapeerzada wants to merge 2 commits intoCCExtractor:masterfrom
sadiapeerzada wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
…) may return NULL if memory allocation fails. Added checks and call to fatal(EXIT_NOT_ENOUGH_MEMORY) to prevent potential NULL dereference. Added memory allocation check for language string.
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 90128d8...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strdup("eng") may return NULL if memory allocation fails.
This patch adds a NULL check after strdup and calls
fatal(EXIT_NOT_ENOUGH_MEMORY) to prevent a potential
NULL pointer dereference.