Warn against semicolons in categorisation rules editor#724
Open
AbdulGoodLooks wants to merge 2 commits intoActivityWatch:masterfrom
Open
Warn against semicolons in categorisation rules editor#724AbdulGoodLooks wants to merge 2 commits intoActivityWatch:masterfrom
AbdulGoodLooks wants to merge 2 commits intoActivityWatch:masterfrom
Conversation
Workaround to attempt to prevent creating rules that break aw-server like this https://forum.activitywatch.net/t/invalid-syntax-for-value-to-assign-out-of-nowhere/4627/3
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 93f4484 in 1 minute and 31 seconds. Click for details.
- Reviewed
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/util/validate.ts:6
- Draft comment:
Document the rationale further: consider adding the forum post URL in the comment so future maintainers understand why semicolons break aw-server. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to document the rationale further by adding a URL to a forum post. This is a request for additional documentation, which is not allowed according to the rules. The comment does not provide a specific code suggestion or ask for a test to be written, so it should be removed.
Workflow ID: wflow_E2xAh4bMlQ1LhDNM
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
==========================================
- Coverage 26.30% 26.29% -0.02%
==========================================
Files 29 29
Lines 1684 1685 +1
Branches 301 302 +1
==========================================
Hits 443 443
+ Misses 1219 1180 -39
- Partials 22 62 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround to attempt to prevent creating rules that break aw-server like this https://forum.activitywatch.net/t/invalid-syntax-for-value-to-assign-out-of-nowhere/4627/3
Important
Update
validateRegexto flag semicolons in regex as invalid to prevent server errors.validateRegexinvalidate.tsto returnfalseif regex contains semicolons, preventing server errors.aw-server.This description was created by
for 93f4484. You can customize this summary. It will automatically update as commits are pushed.