From 9bacc129e7a95f52ae0b6a9fdd04633dcee5e58a Mon Sep 17 00:00:00 2001 From: Mahjabin Oyshi Date: Fri, 6 Mar 2026 21:24:21 +0600 Subject: [PATCH 1/3] Add issue template for revdep check failures Based on Revdep checks and revdep issue template wiki pages (implements issue #7658) --- .../ISSUE_TEMPLATE/revdep-check-failure.md | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/revdep-check-failure.md diff --git a/.github/ISSUE_TEMPLATE/revdep-check-failure.md b/.github/ISSUE_TEMPLATE/revdep-check-failure.md new file mode 100644 index 0000000000..2aa2d6286b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/revdep-check-failure.md @@ -0,0 +1,30 @@ +--- + +name: Revdep check failure + +about: Contact a reverse dependency maintainer about a new check failure caused by data.table changes + +title: "\[revdep] YOUR\_PACKAGE: new check failure with data.table master" + +labels: \[] + +assignees: \[] + +--- + + + +Hi @MAINTAINER, + + + +After installing \*\*data.table\*\* from GitHub master + + + +```r + +data.table::update\_dev\_pkg() + + + From 608ba17bdb7de3b952b347e22cdf235bf4368d74 Mon Sep 17 00:00:00 2001 From: Mahjabin Oyshi Date: Fri, 6 Mar 2026 21:43:12 +0600 Subject: [PATCH 2/3] Clean formatting of revdep check failure template --- .../ISSUE_TEMPLATE/revdep-check-failure.md | 98 ++++++++++++++++++- 1 file changed, 97 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/revdep-check-failure.md b/.github/ISSUE_TEMPLATE/revdep-check-failure.md index 2aa2d6286b..9c971db22e 100644 --- a/.github/ISSUE_TEMPLATE/revdep-check-failure.md +++ b/.github/ISSUE_TEMPLATE/revdep-check-failure.md @@ -23,8 +23,104 @@ After installing \*\*data.table\*\* from GitHub master ```r - data.table::update\_dev\_pkg() +``` + + + +and then running `R CMD check` on \*\*YOUR\_PACKAGE\*\*, I get the following new failure, which is \*\*not present\*\* when using data.table from CRAN. + + + + + +\## Package and environment + + + +\- Package: YOUR\_PACKAGE + +\- Package version: YOUR\_PACKAGE\_VERSION + +\- R version(s): R\_RELEASE\_AND\_OR\_R\_DEVEL + +\- data.table versions: + +  - CRAN: DT\_CRAN\_VERSION + +  - GitHub master: DT\_MASTER\_SHA\_OR\_VERSION + +\- Platform: OS / architecture (for example, linux-x86\_64) + + + +\## Related data.table issue and commit + + + +We track this revdep failure in the data.table issue tracker here: + + + +\- Data.table issue: https://github.com/Rdatatable/data.table/issues/REVDEP\_ISSUE\_NUMBER + +\- First bad commit (from revdep checks): https://github.com/Rdatatable/data.table/commit/FIRST\_BAD\_COMMIT\_SHA + + + + + +\## Check output + + + +Below is the relevant part of the failing check log: + + + +```text +OUTPUT\_FROM\_FAILING\_CHECK +``` + + + +\## Suggested fix + + + +Before uploading new versions to CRAN, \*\*data.table\*\* needs to ensure that updates do not break CRAN checks in dependent packages like \*\*YOUR\_PACKAGE\*\*. So can you please submit an updated version of \*\*YOUR\_PACKAGE\*\* to CRAN that fixes this check issue? + + + +In particular, I would suggest to avoid + + + +> DOING\_WHAT\_YOU\_ARE\_DOING\_CURRENTLY + + + +and instead + + + +> DOING\_SOMETHING\_MORE\_ROBUST. + + + +(If we have a more specific suggestion or PR, we will add it here.) + + + +\## Additional context (optional) + + + +\- Minimal reproducible example, if available. + +\- Links to previous revdep check runs or CRAN check results for YOUR\_PACKAGE. + +\- Any notes that might help debug. From 5338a8fa372b111428e9752826dda26038bdd266 Mon Sep 17 00:00:00 2001 From: Mahjabin Siddika Oyshi Date: Fri, 6 Mar 2026 23:01:05 +0600 Subject: [PATCH 3/3] Fix escaping in revdep issue template --- .../ISSUE_TEMPLATE/revdep-check-failure.md | 137 ++++-------------- 1 file changed, 28 insertions(+), 109 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/revdep-check-failure.md b/.github/ISSUE_TEMPLATE/revdep-check-failure.md index 9c971db22e..fc9ac6ec28 100644 --- a/.github/ISSUE_TEMPLATE/revdep-check-failure.md +++ b/.github/ISSUE_TEMPLATE/revdep-check-failure.md @@ -1,126 +1,45 @@ --- - name: Revdep check failure - about: Contact a reverse dependency maintainer about a new check failure caused by data.table changes - -title: "\[revdep] YOUR\_PACKAGE: new check failure with data.table master" - -labels: \[] - -assignees: \[] - +title: "[revdep] YOUR_PACKAGE: new check failure with data.table master" +labels: [] +assignees: [] --- - - - Hi @MAINTAINER, - - - -After installing \*\*data.table\*\* from GitHub master - - - +After installing **data.table** from GitHub master ```r -data.table::update\_dev\_pkg() +data.table::update_dev_pkg() ``` - - - -and then running `R CMD check` on \*\*YOUR\_PACKAGE\*\*, I get the following new failure, which is \*\*not present\*\* when using data.table from CRAN. - - - - - -\## Package and environment - - - -\- Package: YOUR\_PACKAGE - -\- Package version: YOUR\_PACKAGE\_VERSION - -\- R version(s): R\_RELEASE\_AND\_OR\_R\_DEVEL - -\- data.table versions: - -  - CRAN: DT\_CRAN\_VERSION - -  - GitHub master: DT\_MASTER\_SHA\_OR\_VERSION - -\- Platform: OS / architecture (for example, linux-x86\_64) - - - -\## Related data.table issue and commit - - - -We track this revdep failure in the data.table issue tracker here: - - - -\- Data.table issue: https://github.com/Rdatatable/data.table/issues/REVDEP\_ISSUE\_NUMBER - -\- First bad commit (from revdep checks): https://github.com/Rdatatable/data.table/commit/FIRST\_BAD\_COMMIT\_SHA - - - - - -\## Check output - - - +and then running `R CMD check` on **YOUR_PACKAGE**, I get the following new failure, which is **not present** when using data.table from CRAN. +## Package and environment +- Package: YOUR_PACKAGE +- Package version: YOUR_PACKAGE_VERSION +- R version(s): R_RELEASE_AND_OR_R_DEVEL +- data.table versions: + - CRAN: DT_CRAN_VERSION + - GitHub master: DT_MASTER_SHA_OR_VERSION +- Platform: OS / architecture (for example, linux-x86_64) +## Related data.table issue and commit +- Data.table issue: https://github.com/Rdatatable/data.table/issues/REVDEP_ISSUE_NUMBER +- First bad commit (from revdep checks): https://github.com/Rdatatable/data.table/commit/FIRST_BAD_COMMIT_SHA +## Check output Below is the relevant part of the failing check log: - - - ```text -OUTPUT\_FROM\_FAILING\_CHECK +OUTPUT_FROM_FAILING_CHECK ``` - - - -\## Suggested fix - - - -Before uploading new versions to CRAN, \*\*data.table\*\* needs to ensure that updates do not break CRAN checks in dependent packages like \*\*YOUR\_PACKAGE\*\*. So can you please submit an updated version of \*\*YOUR\_PACKAGE\*\* to CRAN that fixes this check issue? - - - +## Suggested fix +Before uploading new versions to CRAN, **data.table** needs to ensure that updates do not break CRAN checks in dependent packages like **YOUR_PACKAGE**. So can you please submit an updated version of **YOUR_PACKAGE** to CRAN that fixes this check issue? In particular, I would suggest to avoid +> DOING_WHAT_YOU_ARE_DOING_CURRENTLY +... +> DOING_SOMETHING_MORE_ROBUST. +## Additional context (optional) +- Minimal reproducible example, if available. +- Links to previous revdep check runs or CRAN check results for YOUR_PACKAGE. +- Any notes that might help debug. -> DOING\_WHAT\_YOU\_ARE\_DOING\_CURRENTLY - - - -and instead - - - -> DOING\_SOMETHING\_MORE\_ROBUST. - - - -(If we have a more specific suggestion or PR, we will add it here.) - - - -\## Additional context (optional) - - - -\- Minimal reproducible example, if available. - -\- Links to previous revdep check runs or CRAN check results for YOUR\_PACKAGE. - -\- Any notes that might help debug.